Skip to content

[Dashboard] Remove react-children-utilities #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Dashboard] Remove react-children-utilities #5275

wants to merge 1 commit into from

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 3, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating the package.json and pnpm-lock.yaml files by removing the react-children-utilities dependency and replacing its functionality with custom utility functions in the markdown-renderer.tsx file.

Detailed summary

  • Removed react-children-utilities dependency from package.json and pnpm-lock.yaml.
  • Added custom onlyText and childToString utility functions in markdown-renderer.tsx to handle child elements.
  • Updated imports in markdown-renderer.tsx to use React's Children and isValidElement.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 55560ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:26am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:26am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:26am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:26am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review November 3, 2024 04:03
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 3, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Nov 3, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo mentioned this pull request Nov 3, 2024
Closed
@codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (1e141f3) to head (55560ef).

Additional details and impacted files 
@@                         Coverage Diff                         @@
##           kien/remove-use-scroll-position    #5275      +/-   ##
===================================================================
- Coverage                            45.56%   45.55%   -0.01%     
===================================================================
  Files                                 1067     1068       +1     
  Lines                                55487    55514      +27     
  Branches                              4031     4029       -2     
===================================================================
+ Hits                                 25282    25292      +10     
- Misses                               29515    29532      +17     
  Partials                               690      690
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c63fefd
packages 40.65% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 860 ms (0%) 2.1 s (-35.46% 🔽) 3 s
thirdweb (cjs) 102.98 KB (0%) 2.1 s (0%) 4.7 s (-13.23% 🔽) 6.8 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 178 ms (-37.82% 🔽) 275 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 137 ms (+39.2% 🔺) 147 ms
thirdweb/react (minimal + tree-shaking) 17.57 KB (0%) 352 ms (0%) 565 ms (-5.47% 🔽) 916 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 4, 2024
@gregfromstl Graphite App
Copy link
Contributor

gregfromstl commented Nov 4, 2024

Merge activity

  • Nov 4, 3:05 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@kien-ngo kien-ngo force-pushed the kien/remove-use-scroll-position branch from 106b814 to 1e141f3 Compare November 5, 2024 04:16
@kien-ngo kien-ngo force-pushed the kien/remove-react-children-utilities branch from b4938e7 to 55560ef Compare November 5, 2024 04:16
@socket-security
Copy link

socket-security bot commented Nov 5, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/react-children-utilities@2.10.0

View full report↗︎

@kien-ngo kien-ngo closed this Nov 5, 2024
@kien-ngo kien-ngo deleted the kien/remove-react-children-utilities branch January 6, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

1 more reviewer

@gregfromstl gregfromstl gregfromstl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kien-ngo kien-ngo

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kien-ngo @gregfromstl